-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: include last security release date #44794
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vdeturckheim many thanks! |
Commit Queue failed- Loading data for nodejs/node/pull/44794 ✔ Done loading data for nodejs/node/pull/44794 ----------------------------------- PR info ------------------------------------ Title doc: include last security release date (#44794) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch vdeturckheim:master -> nodejs:main Labels doc Commits 2 - doc: include last security release date - Update doc/contributing/security-release-process.md Committers 2 - Vladimir de Turckheim - GitHub PR-URL: https://github.com/nodejs/node/pull/44794 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44794 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 26 Sep 2022 08:30:38 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44794#pullrequestreview-1120734169 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44794#pullrequestreview-1120742370 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/44794#pullrequestreview-1120790967 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/44794#pullrequestreview-1121026499 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44794#pullrequestreview-1127612943 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 44794 From https://github.com/nodejs/node * branch refs/pull/44794/merge -> FETCH_HEAD ✔ Fetched commits as ce59abceb41c..6a424811d566 -------------------------------------------------------------------------------- [main 7a92b6a3cb] doc: include last security release date Author: Vladimir de Turckheim Date: Mon Sep 26 10:29:31 2022 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [main 51aaa05a34] Update doc/contributing/security-release-process.md Author: Vladimir de Turckheim Date: Mon Sep 26 10:33:48 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/3168011168 |
Landed in dc96633 |
PR-URL: #44794 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Ref. 7e0097d